Conversation
vaibhavjuspay
left a comment
vaibhavjuspay
left a comment
There was a problem hiding this comment.
@chikkibum I just reviewed the PR, added some comments please check those.
| ) | ||
|
|
||
|
|
||
| if [ -f "$ZIP_FILE" ]; then |
There was a problem hiding this comment.
Won't it be better to add a prompt asking the user whether to overwrite the existing file ?
plugin.sh
Outdated
|
|
||
| zip -r "$ZIP_FILE" "$PLUGIN_DIR" "${EXCLUDE_PARAMS[@]}" | ||
|
|
||
| echo "zip file created: $ZIP_FILE" No newline at end of file |
There was a problem hiding this comment.
It will be better to check the exit status of the zip command as if there’s an issue with file permissions, disk space, or other problems, the script will continue and may report success even if the ZIP creation failed.
|
I'll make the suggested changes the . |
|
hey @chikkibum please remove the woocommerce-plugin.zip file. |
|
Will do |
|
Hey @chikkibum |
Made the required changes as per the suggestions, if anything else can be made better do tell me . Thank you |
4 participants
bash script for zipping wooCommerce plugin according to issue 6173